[SYCL] Align some extensions with SYCL 2020 #4432
Conversation
This patch 1. aligns these extensions with SYCL 2020 [section intel#6 in the spec]: - Enqueue barrier [SYCL_EXT_INTEL_ENQUEUE_BARRIER] - Level Zero backend [SYCL_EXT_ONEAPI_BACKEND_LEVEL_ZERO] - Local memory [SYCL_EXT_ONEAPI_LOCAL_MEMORY] - mem_channel property [SYCL_EXT_INTEL_MEM_CHANNEL_PROPERTY] - USM address spaces [SYCL_EXT_INTEL_USM_ADDRESS_SPACES] 2. deprecates these extensions: - sycl::detail::bit_cast [SYCL_INTEL_bitcast] 3. changes the location of these extensions: - sycl::ext::intel::online_compiler moves to sycl::ext::intel::experimental. sycl::ext::intel::online_compiler is deprecated.
…date-oneapi-and-intel-extensions
|
FAIL: SYCL::bfloat16.cpp in buildbot/Lit_With_Cuda is a common issue. |
It's already resolved. You can restart the tests to get relevant results. |
|
@intel/dpcpp-specification-reviewers, please review. |
|
@rolandschulz @Pennycook @jbrodman @gmlueck @mkinsner, friendly reminder. |
|
@v-klochkov @GarveyJoe @MrSidims @smaslov-intel for awareness. |
|
No objections from my side. |
…ttps://github.com/dm-vodopyanov/llvm into private/dvodopya/update-oneapi-and-intel-extensions
|
Added @GarveyJoe to review "USM address spaces" spec changes. |
|
LGTM |
|
@dm-vodopyanov This PR is huge - 26 files and it changes many various things. The description says there are 3 major changes that seem independent from each other. It is difficult to review one huge PR. 3 separate may be often reviewed/merged faster than 1 big PR. |
There was a problem hiding this comment.
I think more work needs to be done to these extension specifications before they are fully aligned with SYCL 2020. Some of them still say they are based on SYCL 1.2.1, and they still contain references to specific sections in SYCL 1.2.1. If it was your intent to fully align these extensions, I think these changes should be made also.
sycl/doc/extensions/USMAddressSpaces/usm_address_spaces.asciidoc
Outdated
Show resolved
Hide resolved
dm-vodopyanov
requested review from
Pennycook,
jbrodman,
gmlueck,
bader and
vladimirlaz
sycl/doc/extensions/USMAddressSpaces/usm_address_spaces.asciidoc
Outdated
Show resolved
Hide resolved
…ttps://github.com/dm-vodopyanov/llvm into private/dvodopya/update-oneapi-and-intel-extensions
…date-oneapi-and-intel-extensions
|
@gmlueck, can you please review? |
This patch 1. aligns these extensions with SYCL 2020 [section #6 in the spec]: - Enqueue barrier [SYCL_EXT_INTEL_ENQUEUE_BARRIER] - Level Zero backend [SYCL_EXT_ONEAPI_BACKEND_LEVEL_ZERO] - Local memory [SYCL_EXT_ONEAPI_LOCAL_MEMORY] - mem_channel property [SYCL_EXT_INTEL_MEM_CHANNEL_PROPERTY] - USM address spaces [SYCL_EXT_INTEL_USM_ADDRESS_SPACES] 2. deprecates these extensions: - sycl::detail::bit_cast [SYCL_INTEL_bitcast] 3. changes the location of these extensions: - sycl::ext::intel::online_compiler moves to sycl::ext::intel::experimental. sycl::ext::intel::online_compiler is deprecated.
dm-vodopyanov
deleted the
private/dvodopya/update-oneapi-and-intel-extensions
branch
This patch
aligns these extensions with SYCL 2020 [section 6 in the spec]:
partially aligns with SYCL 2020:
deprecates this extension:
changes the location of this extension:
sycl::ext::intel::online_compiler is deprecated.